Skip to content

Marcinzo/issuervalidatormetadata#2480

Merged
MZOLN merged 10 commits into
devfrom
marcinzo/issuervalidatormetadata
Feb 24, 2024
Merged

Marcinzo/issuervalidatormetadata#2480
MZOLN merged 10 commits into
devfrom
marcinzo/issuervalidatormetadata

Conversation

@MZOLN

@MZOLN MZOLN commented Feb 3, 2024

Copy link
Copy Markdown
Contributor

PoC injecting metadata configuration managers from outside for single point cache management

This PR adds injection point to AadIssuerValidator for ConfigurationManager

Description

This PR allows for centralized cache management, including http policies, lifetime policies, etc. and reduces the amount of copies
of cached data.

This is a conservative change, that still utilizes prev mechanism for a fallback in case the cache cannot be retrieved.

{Detail}

Fixes #{bug number} (in this specific format)

Comment thread src/Microsoft.IdentityModel.Validators/AadIssuerValidator/AadIssuerValidator.cs Outdated
Comment thread src/Microsoft.IdentityModel.Validators/AadIssuerValidator/AadIssuerValidator.cs Outdated
Comment thread src/Microsoft.IdentityModel.Validators/AadIssuerValidator/AadIssuerValidator.cs Outdated
Comment thread src/Microsoft.IdentityModel.Validators/AadIssuerValidator/AadIssuerValidator.cs Outdated

@brentschmaltz brentschmaltz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

examine if LKG should be set in AADIssuerValidator.

@MZOLN MZOLN force-pushed the marcinzo/issuervalidatormetadata branch from 95dfb3a to 6446b9f Compare February 22, 2024 22:54
Comment thread src/Microsoft.IdentityModel.Validators/AadIssuerValidator/AadIssuerValidator.cs Outdated
@MZOLN MZOLN requested a review from brentschmaltz February 23, 2024 02:51
@MZOLN MZOLN force-pushed the marcinzo/issuervalidatormetadata branch from 0bae247 to 12267cf Compare February 23, 2024 20:29
@MZOLN MZOLN force-pushed the marcinzo/issuervalidatormetadata branch from 12267cf to 42c88ac Compare February 23, 2024 22:50
@MZOLN MZOLN merged commit d28f795 into dev Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants